Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FilterService: when integer passed for global search, search only in model id #1152

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

skelz0r
Copy link
Contributor

@skelz0r skelz0r commented Aug 23, 2023

No description provided.

@skelz0r skelz0r self-assigned this Aug 23, 2023
@skelz0r
Copy link
Contributor Author

skelz0r commented Aug 23, 2023

@Samuelfaure @Un3x related https://mattermost.incubateur.net/betagouv/pl/6c6nrmuuu3ypt8ds8dbyj1nnwa

je vous invite à ne pas trop fouiller le code parce que sinon ça va être monster refacto et 1 milliards de question avec Q&A infinie 😅

Copy link
Contributor

@Un3x Un3x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bon du coup je dis rien :D.
En vrai ca match avec la conversation, et je vois pas l'intérêt de refacto ce qui fonctionne si on a pas d'autres ambitions court terme d'améliorer donc IMO c'est bon.

@skelz0r skelz0r merged commit 8afde52 into master Aug 24, 2023
7 checks passed
@skelz0r skelz0r deleted the enhancement/search-on-id-only branch August 24, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants